Skip to content

Allow files to be named _.config.js #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2022
Merged

Allow files to be named _.config.js #185

merged 1 commit into from
Jan 24, 2022

Conversation

keithamus
Copy link
Contributor

We allow many files to be named *.config.js, e.g. postcss.config.js, rollup.config.js, karma.config.cjs.

This should be allowed in the lint rule, without having to override it.

@keithamus keithamus requested a review from a team as a code owner January 21, 2022 12:34
koddsson
koddsson approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@koddsson koddsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@koddsson koddsson merged commit d032563 into main Jan 24, 2022
@koddsson koddsson deleted the allow-config-files branch January 24, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfuchs jfuchs Awaiting requested review from jfuchs jfuchs is a code owner automatically assigned from github/web-systems-reviewers

@JoseInTheArena JoseInTheArena Awaiting requested review from JoseInTheArena JoseInTheArena is a code owner automatically assigned from github/web-systems-reviewers

1 more reviewer

@koddsson koddsson koddsson approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keithamus @koddsson